Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dist from __all__? #52

Open
jGaboardi opened this issue Jun 22, 2024 · 1 comment · May be fixed by #66
Open

remove dist from __all__? #52

jGaboardi opened this issue Jun 22, 2024 · 1 comment · May be fixed by #66
Assignees
@carsonfarmer @jGaboardi
Labels
question

Comments

@jGaboardi
Copy link
Collaborator

Does dist (scipy.spatial.distance) actually need to be listed in all? I think we can remove, but wanted to see if I'm missing something.
@carsonfarmer
Copy link
Owner

Ah nice catch, I don't think it is needed there, no. We can remove. Better to explicitly import it anyway.

@jGaboardi jGaboardi linked a pull request Jul 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carsonfarmer carsonfarmer

@jGaboardi jGaboardi

Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update scipy import jGaboardi/fastpair
2 participants
@carsonfarmer @jGaboardi