Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Json?, and String? as the response in a RequestView #1

Open
carson-katri opened this issue Jul 14, 2019 · 3 comments
Open
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@carson-katri
Copy link
Owner

Currently, RequestView only supports Data? as a return type.

This enhancement is to allow Json? and String? as responses as well by adding more initializers:

RequestView(myRequest) { (data: Data?) in ... }
RequestView(myRequest) { (string: String?) in ... }
RequestView(myRequest) { (json: Json?) in ... }
@carson-katri carson-katri added the enhancement New feature or request label Jul 14, 2019
@carson-katri carson-katri self-assigned this Jul 14, 2019
@carson-katri carson-katri added this to the v1.1.0 milestone Jul 14, 2019
@carson-katri carson-katri modified the milestones: v1.1.0, v1.2.0 Jul 29, 2019
@carson-katri
Copy link
Owner Author

Codable support is now available in RequestView #4
Json and String are stilled planned.

@carson-katri
Copy link
Owner Author

I'm pushing this to v1.3.0 because it requires more than implementing more initializers...

@carson-katri carson-katri modified the milestones: v1.2.0, v1.3.0 Oct 21, 2019
@carson-katri carson-katri modified the milestones: v1.3.0, v1.4.0 Jul 27, 2020
@carson-katri
Copy link
Owner Author

I'm pushing this again 😄 I want to tag 1.3.0 now so people can use the new error and timeout additions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant