Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating cluster computer slide presenter notes. #422

Conversation

lcoghill
Copy link
Contributor

Updating presenter notes for cluster computer that were duplicated from the "cloud computing" slides. Attempting to address issue 419.

Updating presenter notes for cluster computer that were duplicated from the "cloud computing" slides. Attempting to address issue [419](carpentries-incubator#419).
files/jargon.html Outdated Show resolved Hide resolved
Copy link
Contributor

@reid-a reid-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar error on line 149 -- hopefully an easy fix!

@reid-a
Copy link
Contributor

reid-a commented Sep 26, 2022

Thanks for this! I did catch one apparent grammar error in the change, it's noted above, but I think it's an easy fix.

Also, apparently your contribution is failing the continuous-integration workflow with a spelling error ("scrip" for "script') in README.md, which I think you did not modify? So I'm not sure I understand that part.

@reid-a
Copy link
Contributor

reid-a commented Sep 26, 2022

I have made a separate PR, #423, which addresses the CI build error -- once that's merged into the main repo, and incorporated into this PR, things should work.

@reid-a
Copy link
Contributor

reid-a commented Sep 29, 2022

I have taken the liberty of updating the branch upstream to incorporate the spelling correction -- once the requested changes have been made, this PR should be good to merge, assuming the CI runs successfully.

@reid-a
Copy link
Contributor

reid-a commented Sep 29, 2022

I should say, once the requested changes have been addressed -- you don't have to do what was asked, but you do need to either make the case for the existing version, or propose other changes. Thanks again for contributing!

@reid-a
Copy link
Contributor

reid-a commented Oct 6, 2022

I have taken the liberty of making my requested grammar fix directly on the branch. Will merge ASAP.

Should not be taken to detract from the value of this contribution, this is terrific!

@reid-a reid-a merged commit 2c3f09d into carpentries-incubator:gh-pages Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants