-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating cluster computer slide presenter notes. #422
Updating cluster computer slide presenter notes. #422
Conversation
Updating presenter notes for cluster computer that were duplicated from the "cloud computing" slides. Attempting to address issue [419](carpentries-incubator#419).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar error on line 149 -- hopefully an easy fix!
Thanks for this! I did catch one apparent grammar error in the change, it's noted above, but I think it's an easy fix. Also, apparently your contribution is failing the continuous-integration workflow with a spelling error ("scrip" for "script') in README.md, which I think you did not modify? So I'm not sure I understand that part. |
I have made a separate PR, #423, which addresses the CI build error -- once that's merged into the main repo, and incorporated into this PR, things should work. |
I have taken the liberty of updating the branch upstream to incorporate the spelling correction -- once the requested changes have been made, this PR should be good to merge, assuming the CI runs successfully. |
I should say, once the requested changes have been addressed -- you don't have to do what was asked, but you do need to either make the case for the existing version, or propose other changes. Thanks again for contributing! |
I have taken the liberty of making my requested grammar fix directly on the branch. Will merge ASAP. Should not be taken to detract from the value of this contribution, this is terrific! |
Updating presenter notes for cluster computer that were duplicated from the "cloud computing" slides. Attempting to address issue 419.