Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import schnorrkel plutus #1742

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Import schnorrkel plutus #1742

wants to merge 4 commits into from

Conversation

locallycompact
Copy link
Contributor

  • CHANGELOG updated or not needed
  • Documentation updated or not needed
  • Haddocks updated or not needed
  • No new TODOs introduced or explained herafter

@locallycompact locallycompact force-pushed the lc/schnorrkel branch 6 times, most recently from 1cb11a3 to eb5071d Compare November 19, 2024 16:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

Transaction cost differences

Script summary

Name Size (Bytes)
νInitial -
νCommit -
νHead -
μHead -
νDeposit -

Init transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 - - - -
2 - - - -
3 - - - -
5 - - - -
10 - - - -
24 - - - -

Commit transaction costs

UTxO Tx size % max Mem % max CPU Min fee ₳
1 - - - -
2 - - - -
3 - - - -
5 - - - -
10 - - - -
54 $${\color{green}-1.00}$$ - - -

CollectCom transaction costs

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 - - - - -
2 - - $${\color{green}-1.98}$$ $${\color{green}-0.47}$$ $${\color{green}-0.02}$$
3 - - - - -
4 - - $${\color{green}-0.61}$$ $${\color{green}-0.15}$$ $${\color{green}-0.01}$$
5 - - +1.31 +0.31 +0.01
6 - - +0.4 +0.1 +0.01
7 - - $${\color{green}-1.30}$$ $${\color{green}-0.31}$$ $${\color{green}-0.01}$$
8 - - +4.75 +1.15 +0.04
9 - - +4.91 +1.17 +0.05

Cost of Decrement Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 - - - -
2 - +0.27 +0.06 -
3 - $${\color{green}-0.17}$$ $${\color{green}-0.04}$$ -
5 - $${\color{green}-0.28}$$ $${\color{green}-0.06}$$ $${\color{green}-0.01}$$
10 - +0.17 +0.05 +0.01
45 - +0.05 +0.01 -

Close transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 - - - -
2 - - - -
3 - +0.04 +0.01 -
5 - - - -
10 - - - -

Contest transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 - - - -
2 - - - -
3 - - - -
5 - +0.05 +0.01 +0.01
10 - - - -
34 - +0.09 +0.02 -

Abort transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 - +0.17 +0.04 -
2 - +0.03 +0.01 -
3 - +0.12 +0.03 -
4 - +0.03 - -
5 - $${\color{green}-0.76}$$ $${\color{green}-0.18}$$ $${\color{green}-0.01}$$
6 - $${\color{green}-0.13}$$ $${\color{green}-0.03}$$ $${\color{green}-0.01}$$
7 - $${\color{green}-0.63}$$ $${\color{green}-0.15}$$ $${\color{green}-0.01}$$
8 - $${\color{green}-0.82}$$ $${\color{green}-0.20}$$ -
9 - $${\color{green}-0.57}$$ $${\color{green}-0.14}$$ $${\color{green}-0.01}$$
10 - $${\color{green}-0.29}$$ $${\color{green}-0.08}$$ -

FanOut transaction costs

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
10 - - - - - -
10 - - - - - -
10 - - - - - -
10 - - - - - -
10 - - - - - -
10 - - - - - -
10 - - - - - -
10 - - - - - -

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

Transaction costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2024-12-12 10:00:20.732066089 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial 00a6ddbc130ab92f5b7cb8d1ccd8d79eca5bfe25f6843c07b62841f0 2667
νCommit 3e5a776bcee213e3dfd15806952a10ac5590e3e97d09d62eb99266b2 690
νHead 8fc2a74df32d01d1db56b3acb561831ef9c9970123079423abfcb86e 12622
μHead 2552bdb8ba1af4d9e7932f85ca45e13694abbff4d6799e87163169bb* 11133
νDeposit 2feb47889a4f658dc593cefcb0e37d584b9431944f08a687f3dab4af 4865
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per head.

Init transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 11718 8.84 2.88 0.76
2 11919 10.79 3.53 0.79
3 12119 12.55 4.10 0.81
5 12521 15.73 5.11 0.87
10 13532 24.90 8.11 1.01
24 16344 49.51 16.10 1.39

Commit transaction costs

This uses ada-only outputs for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 563 2.45 1.17 0.20
2 740 3.40 1.74 0.22
3 923 4.39 2.34 0.24
5 1283 6.46 3.61 0.29
10 2173 12.24 7.28 0.40
54 10059 99.20 68.72 1.89

CollectCom transaction costs

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 56 559 24.12 7.06 0.42
2 114 671 32.69 9.49 0.51
3 169 782 40.47 11.74 0.60
4 227 893 50.10 14.45 0.70
5 283 1004 63.05 17.92 0.83
6 338 1116 71.40 20.47 0.92
7 395 1227 75.04 21.61 0.97
8 449 1338 80.28 23.36 1.03
9 506 1449 94.80 27.25 1.18

Cost of Decrement Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 624 22.35 7.24 0.41
2 810 24.86 8.61 0.45
3 903 24.72 9.21 0.46
5 1320 31.81 12.54 0.56
10 2030 38.88 17.86 0.68
44 6964 98.18 57.19 1.66

Close transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 663 24.43 8.03 0.43
2 808 25.99 9.20 0.46
3 931 27.54 10.35 0.49
5 1251 30.99 12.90 0.55
10 2032 40.64 19.57 0.71
44 6844 96.43 60.64 1.67

Contest transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 675 30.47 9.64 0.50
2 810 32.36 10.89 0.53
3 1073 35.31 12.69 0.57
5 1266 38.31 14.84 0.62
10 2134 49.98 22.20 0.81
35 5655 98.74 54.46 1.59

Abort transaction costs

There is some variation due to the random mixture of initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 11593 25.66 8.74 0.93
2 11730 34.01 11.57 1.02
3 11836 42.51 14.44 1.12
4 12042 49.75 16.97 1.20
5 12209 61.54 20.97 1.34
6 12369 72.50 24.87 1.46
7 12567 80.54 27.55 1.55
8 12417 83.52 28.38 1.58
9 12758 98.35 33.60 1.75

FanOut transaction costs

Involves spending head output and burning head tokens. Uses ada-only UTXO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
10 0 0 11714 17.71 6.07 0.85
10 1 57 11748 19.19 6.70 0.87
10 5 285 11884 26.23 9.61 0.95
10 10 569 12054 35.86 13.55 1.07
10 20 1138 12392 54.01 21.03 1.28
10 30 1707 12733 73.64 29.05 1.51
10 40 2278 13074 91.07 36.27 1.72
10 44 2503 13207 99.53 39.70 1.82

End-to-end benchmark results

This page is intended to collect the latest end-to-end benchmark results produced by Hydra's continuous integration (CI) system from the latest master code.

Please note that these results are approximate as they are currently produced from limited cloud VMs and not controlled hardware. Rather than focusing on the absolute results, the emphasis should be on relative results, such as how the timings for a scenario evolve as the code changes.

Generated at 2024-12-12 10:04:45.45744409 UTC

Baseline Scenario

Number of nodes 1
Number of txs 300
Avg. Confirmation Time (ms) 4.205867256
P99 11.139198479999989ms
P95 5.129847450000001ms
P50 3.977764ms
Number of Invalid txs 0

Three local nodes

Number of nodes 3
Number of txs 900
Avg. Confirmation Time (ms) 23.215603723
P99 116.71821007999998ms
P95 31.256019300000002ms
P50 20.195238500000002ms
Number of Invalid txs 0

@github-actions GitHub Actions
Copy link

Test Results

  5 files  ±0  161 suites  ±0   28m 7s ⏱️ - 2m 25s
552 tests ±0  545 ✅ ±0  7 💤 ±0  0 ❌ ±0 
554 runs  ±0  547 ✅ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit eb5071d. ± Comparison against base commit 25f9f72.

noonio
noonio reviewed Nov 20, 2024
View reviewed changes
hydra-cluster/src/Hydra/Cluster/Scenarios.hs Outdated

let tx' = txSpendingUTxO scriptUTxO

send n1 $ input "NewTx" ["transaction" .= tx']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking lovely.

I think the main thing we need here is to close the Head and make sure the UTxO can be fanned out back to L1.

@noonio noonio linked an issue Dec 9, 2024 that may be closed by this pull request
Spike: Custom ledger containing a new primitive operation - can we still decommit/close? #1727
Open
@v0d1ch v0d1ch force-pushed the lc/schnorrkel branch 2 times, most recently from 34a22ea to 23a82ef Compare December 11, 2024 15:38
@v0d1ch
WIP: Improve schnorkel test cases
d180493 
Still getting PPViewHashesDontMatch but this is the final error to solve
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noonio noonio noonio left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spike: Custom ledger containing a new primitive operation - can we still decommit/close?
3 participants
@locallycompact @noonio @v0d1ch