-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SideNav should overlay Content in UIShell #1463
Comments
"Content" is working by removing "bx--content" from "main". The following rule prevented hiding.
But I don't know if this is the correct solution. |
Actually, this possibly should be OS dependent; the paradigm on Android is overlaying the content while on iOS it would be pushing it. Certain native app frameworks already switch accordingly. (The push should not impact the width of the content, just push some of it off screen, though.) |
If I had to choose just one behavior, I would also go with overlay. User agent/system detection code also can be messy. |
When observing the UIShell on a small-width display, then expanding a collapsed SideNav, the SideNav squeezes the Content container. The SideNav should overlay the Content container without impacting the Content's layout.
To reproduce the issue:
Here's the issue in screenshots:
React:
Svelte:
This is a possible duplicate of #516
Thanks for maintaining!
The text was updated successfully, but these errors were encountered: