chore: Replace timestamp in staged bigquery table name with uuid #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Running the utils function
stage_entities_to_bqconcurrently may potentially cause BigQuery tables created to share the same timestamp, up to the second. This will cause data to be appended to the same table unexpected and/or cause other concurrent runs to get a"Precondition check failed" 412 PATCH bigquery update_tableerror from BigQuery as the table they are supposed to write to is changed unexpectedly (by another concurrent run) before the write job begins.The fix introduced simply replaces the timestamp in the table name created with a uuid.