Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard overlaps app #38

Open
frederikheld opened this issue Oct 26, 2024 · 3 comments
Open

Keyboard overlaps app #38

frederikheld opened this issue Oct 26, 2024 · 3 comments

Comments

@frederikheld
Copy link

frederikheld commented Oct 26, 2024

Describe the bug

See screenshots.

keyboard-overlap

Left: app without keyboard as reference. App bar aligned with bottom of the viewport plus safe area inset bottom.

Right: open keyboard overlaps app for an amount of pixels that seems to match the safe area inset bottom (see red boxes).

I've tested this with the current alpha-8, but it's most probably a regression from PR #31.

@tafelnl
Copy link
Member

tafelnl commented Oct 28, 2024

I'm not able to reproduce this. Also it seems weird if #31 would actually cause this. The only thing that that PR takes care of, is making sure that the value won't be less than zero. You could easily test and verify if that's really the case for you by removing the coerceAtLeast(0) part from within Android Studio

@frederikheld
Copy link
Author

frederikheld commented Oct 28, 2024

So maybe I had my own fix in place that now causes the overlap. I'll look into it.

But I don't seem to be the only one with the issue: #31 (comment)

@frederikheld
Copy link
Author

frederikheld commented Nov 6, 2024

I can't see any issue on my side. The last version that works properly for me is alpha.5. All other versions have issues with either too much or too little safe area inset bottom.

But one thing I noticed with all versions: when I open the keyboard, the bottom bar jumps up for "keyboard height + safe area inset bottom" pixels and a brief moment later jumps back to "keyboard height" (which it should be because the keyboard already covers the bottom bar). The same happens the other way round when closing the keyboard.

I assume this happens because "safe area inset bottom" takes a noticeable amount of time to be updated updated.

EDIT: in alpha.8, this behavior means, that the app bar jumps up "keyboard height" pixels but then jumps back to "keyboard height - safe are inset bottom" (as showed in the screenshots). Other from that, I feel no difference between .5 and .8 (they are both very slow in updating the values).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants