Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Remove obsolete modelservice #303

Closed

Conversation

univerone
Copy link
Collaborator

Closes #302

What has been done to verify that this works as intended?

  • replace all the usage of ModelService include docs
  • replace most usage of model vo/bo except profiler and deployer
  • replace the usage of ModelDao
  • remove model_dao file
  • remove ModelService and rename service_.py
  • fix Too much data warning of model delete api
  • add finetuner API test in test_model_api.py
  • split cache_manager from manager.py

Next steps

  • remove all the usages of modelci/types/bo , modelci/types/do and modelci/types/vo
  • fix the deployer and profiler running issues
  • update notebooks and docs

@univerone univerone changed the title Remove obsolete modelservice [WIP]Remove obsolete modelservice May 16, 2021
@univerone univerone requested a review from YuanmingLeee May 16, 2021 14:13
modelci/app/experimental/endpoints/trainer.py Show resolved Hide resolved
@@ -42,7 +42,7 @@ def get_all() -> List[TrainingJob]:

def save(training_job_in: TrainingJobIn) -> str:
model_id = training_job_in.model
if not ModelDAO.exists_by_id(ObjectId(model_id)):
if not service.exists_by_id(str(model_id)):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is exists_by_id accept ObjectID as model id input? If no, you may add this ObjectId support

@univerone univerone closed this Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace current ModelService with service_
2 participants