-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Remove obsolete modelservice #303
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
univerone
changed the title
Remove obsolete modelservice
[WIP]Remove obsolete modelservice
May 16, 2021
@@ -42,7 +42,7 @@ def get_all() -> List[TrainingJob]: | |||
|
|||
def save(training_job_in: TrainingJobIn) -> str: | |||
model_id = training_job_in.model | |||
if not ModelDAO.exists_by_id(ObjectId(model_id)): | |||
if not service.exists_by_id(str(model_id)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is exists_by_id
accept ObjectID as model id input? If no, you may add this ObjectId support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #302
What has been done to verify that this works as intended?
model_dao
fileservice_.py
test_model_api.py
cache_manager
frommanager.py
Next steps
modelci/types/bo
,modelci/types/do
andmodelci/types/vo