You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I feel like the code is a bit busy and hard to follow at times. Can't really find obvious things to clean though.
Status logic can be a bit hard to reason about. Would it be easier to have a private property to make it more explicit? Right now, we return the correct status based on the status of internal timers and emit EventType.StatusChange at correct places. Then again, even if I have a private prop, that logic will still have to live somewhere. The question is which one would be easier to read?
Been thinking about the tiny-timer dependency. I'm already ignoring the tick events from the solve Timer and I have a lot of logic making those two timers work together correctly. Could I come up with an implementation that would remove the dependency and also make the code leaner and more elegant?
Considering adding a noTick option. I can't really be sure if this would be useful but I can think of implementations that would just hook into the other events and read the time from the property at their leisure.
The text was updated successfully, but these errors were encountered:
I feel like the code is a bit busy and hard to follow at times. Can't really find obvious things to clean though.
EventType.StatusChange
at correct places. Then again, even if I have a private prop, that logic will still have to live somewhere. The question is which one would be easier to read?tiny-timer
dependency. I'm already ignoring the tick events from thesolve Timer
and I have a lot of logic making those two timers work together correctly. Could I come up with an implementation that would remove the dependency and also make the code leaner and more elegant?noTick
option. I can't really be sure if this would be useful but I can think of implementations that would just hook into the other events and read the time from the property at their leisure.The text was updated successfully, but these errors were encountered: