Fix HTTP 302 redirects via delegate for identifiers with slashes #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmatney
changed the title
|
@adolski Any ETA on getting PR review and potentially released? |
|
Noting correspondence to UCLA docker-cantaloupe patch: issue-581-v5.0.5.patch |
ksclarke
approved these changes
Aug 27, 2024
|
I think it's great that you provided a couple of unit tests. For us to understand the need better, can you provide a system test so that we can see when you have a certain system configuration, it gives a certain response. |
|
Discussed in the 27th November call that we would merge this and ask for Functional unit tests at a later time. UCLA have this patch in production as part of their Docker release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #581.