Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set text-only macro parameters to end with _text #5323

Open
jmuzina opened this issue Aug 22, 2024 · 2 comments
Open

Set text-only macro parameters to end with _text #5323

jmuzina opened this issue Aug 22, 2024 · 2 comments
Labels
P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4

Comments

@jmuzina
Copy link
Member

jmuzina commented Aug 22, 2024

Component/pattern to amend

Hero & Tiered List

Update all text-only parameters of the hero and tiered list macros to end with _text.

Context

This was determined to be a good semantic way to indicate to users and developers that some parameters are meant to accept string input only.

@jmuzina jmuzina added WG: Proposal Working group proposals and removed WG: Proposal Working group proposals labels Aug 22, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-14403.

This message was autogenerated

@bartaz bartaz added P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4 labels Sep 25, 2024
@bartaz
Copy link
Member

bartaz commented Sep 25, 2024

This is relevant to current work, so we should do it in current codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4
Projects
None yet
Development

No branches or pull requests

2 participants