Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use YaruInfoBox for notification boxes #1010

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

ashuntu
Copy link
Collaborator

@ashuntu ashuntu commented Dec 10, 2024

This effectively aligns the colors correctly with what is used by Yaru for info boxes, which you can see at https://ubuntu.github.io/yaru.dart under the "YaruInfo" tab. Our colors in light mode were identical to Yaru, but dark mode colors were not. This fixes that issue and simplifies the widget code significantly by just using the YaruInfoBox.

This page still needs more changes in the future, but this should be sufficient for notification colors for the time being.

Dark Light
Existing image image
New image image

UDENG-5590

@ashuntu ashuntu self-assigned this Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.41%. Comparing base (d5ce322) to head (2d03b1d).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...bscription_status/subscription_status_widgets.dart 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1010      +/-   ##
==========================================
+ Coverage   89.38%   89.41%   +0.03%     
==========================================
  Files         113      113              
  Lines        7618     7606      -12     
==========================================
- Hits         6809     6801       -8     
+ Misses        632      629       -3     
+ Partials      177      176       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashuntu ashuntu force-pushed the notification-colors branch from adb6945 to 2d03b1d Compare December 11, 2024 18:04
@ashuntu
Copy link
Collaborator Author

ashuntu commented Dec 11, 2024

We miss some opportunity for tests here, where we could mock a launch event for the success link. However, this page is changing somewhat significantly, so I don't think it would be worthwhile for a test for that right now (it wasn't covered previously, anyway).

@ashuntu ashuntu marked this pull request as ready for review December 11, 2024 18:13
@ashuntu ashuntu requested a review from a team as a code owner December 11, 2024 18:13
Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a lovely diff! :)

@ashuntu ashuntu merged commit 51af9dc into main Dec 11, 2024
35 of 36 checks passed
@ashuntu ashuntu deleted the notification-colors branch December 11, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants