Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terraform] github_branch_protection.required_status_checks.contexts are missing #27

Open
jneo8 opened this issue Jun 5, 2024 · 2 comments

Comments

@jneo8
Copy link
Contributor

jneo8 commented Jun 5, 2024

Right now we are missing github_branch_protection.required_status_checks.contexts on github repo settings.

contexts is empty by default; ie. no status checks are required to pass even if required_status_checks is turned on.

We need to set a value per-repository.

@samuelallan72 samuelallan72 changed the title [Terraform] Miss github_branch_protection.required_status_checks.contexts [Terraform] github_branch_protection.required_status_checks.contexts are missing Aug 26, 2024
@aieri
Copy link
Contributor

aieri commented Oct 10, 2024

@jneo8 is this necessary even for projects that use the public runners?

@jneo8
Copy link
Contributor Author

jneo8 commented Oct 11, 2024

The contexts are list of checks you need to pass before merge into protected branch.
This issue is more like a reminder for us to reach a consensus: do we want it or not?

Strictly speaking we may need it for security reason but since we have been not set it up for a long time and we have two approval required rule so I think maybe not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants