Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional Ansible provisioning for centos 7 #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GR360RY
Copy link
Contributor

@GR360RY GR360RY commented Feb 3, 2024

Adds optional Ansible provisioner for centos7 that allows to customize image with arbitrary ansible code.

Relates to #120

@GR360RY
Copy link
Contributor Author

GR360RY commented Feb 5, 2024

@jurekh and @alexsander-souza , please take a look at this pull request. The change is implemented for centos7 only, but if you like the idea, I can provide PRs for other distros as well.

I'd like to hear your thoughts on the idea of switching to ssh communicator as a default option even if nothing is provisioned with ssh/ansible.

@alexsander-souza
Copy link
Contributor

Hi @GR360RY, awesome work.

unfortunately, we cannot accept this PR as it is. Although we certainly don't oppose using Ansible to customize the images, this is not something we are willing to endorse and support out-of-the-box.

I propose we split this patch in two parts, one generic and another Ansible-specific. The former should include only the SSH-communicator related changes, and this is something we are comfortable to merge and maintain in packer-maas. The latter, the Ansible provisioner bits, should become a discourse topic that we can refer to in the README.

Copy link
Contributor

@alexsander-souza alexsander-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, include only the SSH-communicator support

@GR360RY
Copy link
Contributor Author

GR360RY commented Mar 1, 2024

No problem. I'll refactor the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants