From 05e13390a1f1730f209d95fbb72b47f7c0958663 Mon Sep 17 00:00:00 2001 From: Adam Dyess Date: Thu, 23 May 2024 22:13:49 -0500 Subject: [PATCH] Apply suggestions from code review Style fixes from PR Co-authored-by: Ben Hoyt --- lib/charms/operator_libs_linux/v2/snap.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/charms/operator_libs_linux/v2/snap.py b/lib/charms/operator_libs_linux/v2/snap.py index 1d78179b..0021d373 100644 --- a/lib/charms/operator_libs_linux/v2/snap.py +++ b/lib/charms/operator_libs_linux/v2/snap.py @@ -585,7 +585,7 @@ def ensure( ) self._install(channel, cohort, revision) logger.info("The snap installation completed successfully") - elif (revision is None) or (revision != self._revision): + elif revision is None or revision != self._revision: # The snap is installed, but we are changing it (e.g., switching channels). logger.info( "Refreshing snap %s, revision %s, tracking %s", self._name, revision, channel @@ -593,7 +593,7 @@ def ensure( self._refresh(channel=channel, cohort=cohort, revision=revision, devmode=devmode) logger.info("The snap refresh completed successfully") else: - logger.info("Snap refresh was unnecessary %s", self._name) + logger.info("Refresh of snap %s was unnecessary", self._name) self._update_snap_apps() self._state = state