-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix console creation #3826
Fix console creation #3826
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3826 +/- ##
==========================================
+ Coverage 88.94% 89.04% +0.09%
==========================================
Files 256 255 -1
Lines 14584 14582 -2
==========================================
+ Hits 12972 12984 +12
+ Misses 1612 1598 -14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is better indeed 😄 I have only a couple of requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks Trevor!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix console creation
This needs the other side, so merging manually. |
Fixes #3788
Previously the test output would disappear since
StubTerminal*
was being cast toWindowsTerminal*
and thencin
/cout
/cerr
would get deleted. NowStubTerminal*
is not cast at all andConsole
creation is handled by their respective Terminals.MULTI-1676