Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console creation #3826

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Fix console creation #3826

merged 3 commits into from
Dec 18, 2024

Conversation

Sploder12
Copy link
Contributor

Fixes #3788

Previously the test output would disappear since StubTerminal* was being cast to WindowsTerminal* and then cin/cout/cerr would get deleted. Now StubTerminal* is not cast at all and Console creation is handled by their respective Terminals.

MULTI-1676

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.04%. Comparing base (fa725c2) to head (5d97600).
Report is 50 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3826      +/-   ##
==========================================
+ Coverage   88.94%   89.04%   +0.09%     
==========================================
  Files         256      255       -1     
  Lines       14584    14582       -2     
==========================================
+ Hits        12972    12984      +12     
+ Misses       1612     1598      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is better indeed 😄 I have only a couple of requests.

tests/stub_terminal.h Outdated Show resolved Hide resolved
src/client/cli/cmd/shell.cpp Show resolved Hide resolved
Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks Trevor!

@jibel jibel requested a review from sharder996 December 13, 2024 15:53
Copy link
Contributor

@sharder996 sharder996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sharder996 sharder996 added this pull request to the merge queue Dec 17, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@sharder996 sharder996 added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@ricab
Copy link
Collaborator

ricab commented Dec 18, 2024

This needs the other side, so merging manually.

@ricab ricab added this pull request to the merge queue Dec 18, 2024
@ricab ricab removed this pull request from the merge queue due to a manual request Dec 18, 2024
@ricab ricab merged commit eeed24d into main Dec 18, 2024
14 checks passed
@ricab ricab deleted the fix-console-creation-logic branch December 18, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI client tests overwrite console output settings on Windows
3 participants