Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make lvm.conf patching work with lvm2 from 24.04 #589

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Make lvm.conf patching work with lvm2 from 24.04 #589

merged 3 commits into from
Nov 6, 2024

Conversation

simondeziel
Copy link
Member

@simondeziel
daemon.start: use % instead of # with sed
35b74b3 
Also drop `g` flag as those `key = value` only occur once per line anyway.

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
daemon.start: handle commented \key = value\ in lvm.conf
b773a48 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
daemon.start: handle /sbin/ and /bin/ paths in lvm.conf
98f2c84 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
Copy link
Member Author

The change is already deployed and confirm to not break anything.

@simondeziel simondeziel marked this pull request as ready for review November 5, 2024 18:06
tomponline
tomponline approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomponline tomponline merged commit a0a84ce into canonical:latest-edge Nov 6, 2024
5 checks passed
@simondeziel
Copy link
Member Author

The change is already deployed and confirm to not break anything.

This was meant to go in a different PR. I've not tested those LVM changes very thoroughly. I'll quickly look into this. Sorry

@simondeziel
Copy link
Member Author

It seems that only the exec path to dmeventd was not properly covered:

root@v1:~# LD_LIBRARY_PATH=/snap/lxd/current/lib/:/snap/lxd/current/lib/x86_64-linux-gnu/:/snap/lxd/current/zfs-2.2/lib PATH=/snap/lxd/current/zfs-2.2/bin:$PATH nsenter --mount=/run/snapd/ns/lxd.mnt -- grep -E '^\s*(udev_(sync|rules)|monitoring) |executable =' /etc/lvm/lvm.conf
	thin_check_executable = "/snap/lxd/31013/bin/thin_check"
	thin_dump_executable = "/snap/lxd/31013/bin/thin_dump"
	thin_repair_executable = "/snap/lxd/31013/bin/thin_repair"
	cache_check_executable = "/snap/lxd/31013/bin/cache_check"
	cache_dump_executable = "/snap/lxd/31013/bin/cache_dump"
	cache_repair_executable = "/snap/lxd/31013/bin/cache_repair"
	vdo_format_executable = "/snap/lxd/31013/bin/vdoformat"
	fsadm_executable = "/snap/lxd/31013/bin/fsadm"
	udev_sync = 0
	udev_rules = 0
	monitoring = 0
	# executable = "/snap/lxd/31013/bin/dmeventd"

Unfortunately, the udev_sync, udev_rules and monitoring changes didn't seem to have recovered any performance :/

@simondeziel simondeziel deleted the lvm.conf-patching branch November 6, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline tomponline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance regression with lvm (non-thin) on latest/edge snap
2 participants
@simondeziel @tomponline