Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: insecure id not set during registration on self hosted #284

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Fix: insecure id not set during registration on self hosted #284

merged 2 commits into from
Nov 26, 2024

Conversation

david-mclain
Copy link
Contributor

@david-mclain david-mclain commented Nov 7, 2024 •
edited
Loading

Manual Testing

Verify Bug

  • Follow instructions here to install client and use ppa:landscape/self-hosted-beta
  • Connect client to ppa beta version of self hosted server following instructions here
  • After connecting client wait a few minutes and client should go offline as it is not pinging the server

Verify fix

  • Use this version of client
  • Connect client to self hosted server
  • Verify ping is working and connection doesn't go offline

@david-mclain david-mclain changed the title Fix: insecure id not set during silent registration Fix: insecure id not set during registration on self hosted Nov 7, 2024
Perfect5th
Perfect5th requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@Perfect5th Perfect5th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment on test. Otherwise looks good.

landscape/client/tests/test_configuration.py Outdated

mock_setup.assert_called_once()
mock_input.assert_not_called()
mock_set_secure_id.assert_called_once_with(mock.ANY, mock.ANY, 10)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably safest to assert that it's called with mock.ANY, "fake-secure-id", 10.

@david-mclain david-mclain merged commit 0bd090d into canonical:main Nov 26, 2024
5 checks passed
@david-mclain david-mclain deleted the lndeng-1800-insecure-id-fix branch December 2, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perfect5th Perfect5th Perfect5th approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-mclain @Perfect5th