Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add optional installation_request_id parameter to registration … #282

Merged
merged 2 commits into from
Oct 23, 2024
Merged

feat: add optional installation_request_id parameter to registration … #282

merged 2 commits into from
Oct 23, 2024

Conversation

wck0
Copy link
Contributor

@wck0 wck0 commented Oct 21, 2024

…messages

@wck0
Copy link
Contributor Author

wck0 commented Oct 21, 2024

Note: This work is in preparation for server to process this new field. Server does not do that yet, so there isn't much to test out manually.

@silverdrake11
Copy link
Contributor

What's the difference between the hostagent_uid and this installation_request_id ?

@wck0
Copy link
Contributor Author

wck0 commented Oct 23, 2024

What's the difference between the hostagent_uid and this installation_request_id ?

The hostagent_uid uniquely identifies the Windows host machine. The installation_request_id uniquely identifies the activity in Landscape that initiates the installation of the WSL instance.

srunde3
srunde3 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@srunde3 srunde3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left nits inline

landscape/client/broker/tests/test_config.py Outdated Show resolved Hide resolved
landscape/client/broker/config.py Show resolved Hide resolved
@wck0
Copy link
Contributor Author

wck0 commented Oct 23, 2024

Updated

@wck0 wck0 merged commit d9d7418 into canonical:main Oct 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srunde3 srunde3 srunde3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wck0 @silverdrake11 @srunde3