Skip disk/storage_device_.* if disk is not partitioned

[pieqq]

Enhancement Proposal

This desktop PC device has been failing disk/storage_device_sda for quite a while now with output:

Testing disk sda identified as a disk...
ERROR: No suitable partitions found on device /dev/sda 

lsblk attachment job shows

KNAME="sda" TYPE="disk" MOUNTPOINT=""

which indicates that this drive is not mounted, and does not have any partition.

Because of the way provisioning is done in the lab, devices with multiples disks usually only partition one of the disks to install the system, and leave the other disks unpartitioned and unmounted.

This test case should be skipped if the disk is not partitioned.

More information: discussion on Mattermost.

[syncronize-issues-to-jira]

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CHECKBOX-1594.

This message was autogenerated

[rodwsmith]

From a server certification perspective, I don't think that skipping the test if the disk is unpartitioned is the right approach. For server certification, disks are supposed to be partitioned, and a skipped test if a disk is unpartitioned would be bad; the test really should fail in that case, from our perspective. Would it be possible to add a parameter to the test so that it can be called differently for devices, if a skip behavior is preferable there, leaving the existing behavior for server?

[bladernr]

A fairly easy option, I think, would be to add something like a --skip-unpartitioned-disks arg to the disk test and then call that in an SRU test definition or wherever else is appropriate, leaving the default to fail on those disks for cert purposes.

with server cert we do require the OEMs to partition and test any storage device installed in an SUT.

[fernando79513]

This issue has been detected in:

https://certification.canonical.com/hardware/202202-29946/submission/401419/
https://certification.canonical.com/hardware/202102-28728/submission/401428/

The disk/read_performance_.* test, which uses hdparm passes:

Beginning /tmp/nest-k5r6_jbu.4771b438089543e7739528211ff2a826932c860d013d00d54d5faddce42698a2/disk_read_performance_test.sh test for nvme1n1
---------------------------------------------------
INFO: nvme1n1 type is nvme
INFO: nvme: Using 200 MB/sec as the minimum throughput speed
...
PASS: nvme1n1 Max Speed of 2085 MB/sec is faster than Minimum Buffer Read Speed of 200 MB/sec
All devices passed testing!

But after that, the storage tests fail with a similar log:

ERROR: No suitable partitions found on device /dev/nvme1n1
Testing device nvme1n1
identified as a disk...

To Reproduce

• Run checkbox.checkbox-cli run com.canonical.certification::disk-automated on one of this devices
• The disk/storage_device_.* fails for one of the disks

Environment
OS: UC22
checkbox type: snap
Checkbox Version: 4.2.0-dev127
testing: disk

*Duplicated issue