Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dirty workload versions #572

Open
samuelallan72 opened this issue Oct 3, 2024 · 0 comments
Open

Support dirty workload versions #572

samuelallan72 opened this issue Oct 3, 2024 · 0 comments

Comments

@samuelallan72
Copy link
Contributor

Sometimes a workload (probably more likely when testing candidate or edge releases) may not have a clean semantic version, but may have non-standard prerelease or build information. For example we observed workload version 19.2.0~git20240301.4c76c50 for ceph-mon on squid/candidate channel.

COU currently passes the versions directly to packaging.version.Version, which requires version strings to conform to PEP 440. So in this example, COU crashes with an InvalidVersion error.

COU should support comparing these dirty versions. This could be implemented by transforming them to something compatible with Version. Eg. in the case of the ceph-mon example here, it should strip the ~git.... postfix, so it can use 19.2.0 as the version to compare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant