Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back ability to infer fusion type #183

Open
katiestahl opened this issue Aug 22, 2024 · 2 comments
Open

add back ability to infer fusion type #183

katiestahl opened this issue Aug 22, 2024 · 2 comments
Labels
priority:low Low priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"

Comments

@katiestahl
Copy link
Contributor

cancervariants/fusion-curation#314 (comment)

I think from #174, fusion types can no longer be inferred if its elements are missing any types for the fusion elements. We should consider adding validators/some sort of way to add this inference back, if needed? I'm not entirely sure that there's ever a possible case where this would be necessary, but it wouldn't be bad to have.

@katiestahl katiestahl added priority:low Low priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" labels Aug 22, 2024
@jsstevenson
Copy link
Member

Yeah, I don't think this needs to be a high priority. Pretty sure we just included it because we could. If it doesn't get fixed we can let the stalebot eat it.

@katiestahl
Copy link
Contributor Author

Yeah, I don't think this needs to be a high priority. Pretty sure we just included it because we could. If it doesn't get fixed we can let the stalebot eat it.

sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Low priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Development

No branches or pull requests

2 participants