Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(project): use jdk 11 source code level #702

Merged
merged 9 commits into from
Sep 14, 2023

Conversation

yanavasileva
Copy link
Member

@yanavasileva yanavasileva commented Aug 31, 2023

Description

  • bump the release parent version to pick up the source code level changes
  • test feel-scala with JDK 11 and 17

Related issues

camunda/camunda-bpm-platform#3690

@yanavasileva
Copy link
Member Author

@saig0, I am working on switching the source code level to Java 11 in Camunda Platform 7 (camunda/camunda-bpm-platform#3690). Do you think we can and want to bump the source code level of feel-scala project as well? It's no hard requirement but if the other projects using feel-scala already are on higher source code level, we can consider doing it.

@saig0
Copy link
Member

saig0 commented Sep 5, 2023

@yanavasileva awesome. 🚀

Yes, please dump the Java version to 11. 👍 Camunda Platform 8 is already on Java 17. 😁

@yanavasileva yanavasileva force-pushed the 3690-source-code-level-jdk-11 branch from 04cb8ce to ea3c688 Compare September 8, 2023 07:28
@yanavasileva yanavasileva force-pushed the 3690-source-code-level-jdk-11 branch from 0cdc993 to fb5d833 Compare September 11, 2023 12:18
@yanavasileva yanavasileva force-pushed the 3690-source-code-level-jdk-11 branch from 5fd6e30 to ed38de7 Compare September 12, 2023 11:02
@yanavasileva
Copy link
Member Author

yanavasileva commented Sep 13, 2023

@saig0 do you think you can help me resolve the issue on the JDK 17 stage? I see the latest version of scala-maven-plugin is used 4.8.1.

I found the following issues but I can't do much with the information there:

Stacktrace
[2023-09-12T11:08:04.000Z] [INFO] --- scala-maven-plugin:4.8.1:testCompile (scala-test-compile) @ feel-engine ---
[2023-09-12T11:08:04.000Z] [WARNING] Scala library detected 2.13.12 doesn't match scala.compat.version : 2.13.6
[2023-09-12T11:08:04.000Z] [WARNING] Scala library detected 2.13.12 doesn't match scala.compat.version : 2.13.6
[2023-09-12T11:08:04.001Z] [INFO] Compiler bridge file: /home/camunda/.sbt/1.0/zinc/org.scala-sbt/org.scala-sbt-compiler-bridge_2.13-1.8.0-bin_2.13.12__61.0-1.8.0_20221110T195421.jar
[2023-09-12T11:08:04.001Z] [INFO] compiling 47 Scala sources and 3 Java sources to /home/work/workspace/nda-github-org_feel-scala_PR-702/target/test-classes ...
[2023-09-12T11:08:05.906Z] [ERROR] ## Exception when compiling 50 sources to /home/work/workspace/nda-github-org_feel-scala_PR-702/target/test-classes
[2023-09-12T11:08:05.906Z] java.lang.OutOfMemoryError: Metaspace
[2023-09-12T11:08:05.906Z] java.base/java.lang.ClassLoader.defineClass1(Native Method)
[2023-09-12T11:08:05.906Z] java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012)
[2023-09-12T11:08:05.906Z] java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
[2023-09-12T11:08:05.906Z] java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:519)
[2023-09-12T11:08:05.906Z] java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:427)
[2023-09-12T11:08:05.906Z] java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:421)
[2023-09-12T11:08:05.906Z] java.base/java.security.AccessController.executePrivileged(AccessController.java:807)
[2023-09-12T11:08:05.906Z] java.base/java.security.AccessController.doPrivileged(AccessController.java:712)
[2023-09-12T11:08:05.906Z] java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:420)
[2023-09-12T11:08:05.906Z] java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:587)
[2023-09-12T11:08:05.906Z] java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
[2023-09-12T11:08:05.906Z] java.base/java.lang.ClassLoader.defineClass1(Native Method)
[2023-09-12T11:08:05.906Z] java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012)
[2023-09-12T11:08:05.906Z] java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
[2023-09-12T11:08:05.906Z] java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:519)
[2023-09-12T11:08:05.906Z] java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:427)
[2023-09-12T11:08:05.906Z] java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:421)
[2023-09-12T11:08:05.906Z] java.base/java.security.AccessController.executePrivileged(AccessController.java:807)
[2023-09-12T11:08:05.906Z] java.base/java.security.AccessController.doPrivileged(AccessController.java:712)
[2023-09-12T11:08:05.906Z] java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:420)
[2023-09-12T11:08:05.907Z] java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:587)
[2023-09-12T11:08:05.907Z] java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
[2023-09-12T11:08:05.907Z] scala.reflect.internal.SymbolTable.nme$lzycompute$1(SymbolTable.scala:28)
[2023-09-12T11:08:05.907Z] scala.reflect.internal.SymbolTable.nme(SymbolTable.scala:28)
[2023-09-12T11:08:05.907Z] scala.reflect.internal.StdNames.$init$(StdNames.scala:1199)
[2023-09-12T11:08:05.907Z] scala.reflect.internal.SymbolTable.<init>(SymbolTable.scala:28)
[2023-09-12T11:08:05.907Z] scala.tools.nsc.symtab.SymbolTable.<init>(SymbolTable.scala:16)
[2023-09-12T11:08:05.907Z] scala.tools.nsc.Global.<init>(Global.scala:46)
[2023-09-12T11:08:05.907Z] xsbt.CallbackGlobal.<init>(CallbackGlobal.scala:28)
[2023-09-12T11:08:05.907Z] xsbt.ZincCompiler.<init>(CallbackGlobal.scala:77)
[2023-09-12T11:08:05.907Z] xsbt.CachedCompilerCompat.newCompiler(Compat.scala:48)
[2023-09-12T11:08:05.907Z] xsbt.CachedCompilerCompat.newCompiler$(Compat.scala:47)

@saig0
Copy link
Member

saig0 commented Sep 13, 2023

@yanavasileva interesting. 😅

Since this is happening only on Jenkins, we can ignore the failure. I will remove the Jenkins CI integration very soon. All the CI now works on GitHub actions. 🚀

@yanavasileva yanavasileva requested a review from saig0 September 13, 2023 08:45
@yanavasileva yanavasileva marked this pull request as ready for review September 13, 2023 08:45
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanavasileva thank you for your contribution. 🎉

I have a comment about Jenkin. Please have a look.

.ci.cambpm Outdated Show resolved Hide resolved
Co-authored-by: Philipp Ossler <[email protected]>
Copy link
Member

@tmetzke tmetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@saig0 saig0 merged commit f82e02e into main Sep 14, 2023
3 checks passed
@saig0 saig0 deleted the 3690-source-code-level-jdk-11 branch September 14, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants