Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output string which contains not is incorrectly transformed #978

Open
nesies opened this issue Aug 22, 2024 · 1 comment
Open

output string which contains not is incorrectly transformed #978

nesies opened this issue Aug 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@nesies
Copy link

nesies commented Aug 22, 2024

Describe the bug

task output with a value container "not" is wrongly converted to "not" expression

Steps to reproduce

create a Task whichn set a output string containing not:

 <bpmn:task id="Activity_1j6t5uw" name="set var2 str">
      <bpmn:extensionElements>
        <camunda:inputOutput>
          <camunda:outputParameter name="var2">${ "result is not ok" }</camunda:outputParameter>
        </camunda:inputOutput>
      </bpmn:extensionElements>
      <bpmn:incoming>Flow_1yiy9op</bpmn:incoming>
      <bpmn:outgoing>Flow_1x9vzzk</bpmn:outgoing>
    </bpmn:task>

The convert script wrongly converted the string:

      <bpmn:extensionElements>
        <conversion:message severity="REVIEW">Element 'outputParameter' was transformed. Parameter 'var2': Please review transformed expression: '${ "result is not ok" }' -&gt; '="result is not(ok")'.</conversion:message>
        <zeebe:ioMapping>
          <zeebe:output source="=&quot;result is not(ok&quot;)" target="var2"/>
        </zeebe:ioMapping>
      </bpmn:extensionElements>
      <bpmn:incoming>Flow_1yiy9op</bpmn:incoming>
      <bpmn:outgoing>Flow_1x9vzzk</bpmn:outgoing>
    </bpmn:task>

Expected Behaviour

          <zeebe:output source="=&quot;result is not ok&quot;" target="var2"/>

Library version

0.9.0

Camunda Platform 7 version

7.21

Camunda Platform 8 version

8.5

@nesies nesies added bug Something isn't working triage labels Aug 22, 2024
@jonathanlukas jonathanlukas added enhancement New feature or request and removed bug Something isn't working triage labels Dec 2, 2024
@jonathanlukas
Copy link
Collaborator

@nesies as the expression transformer works using regex, this can actually happen.

Therefore, the converter will always display you with a TASK to review the converted expression.

If you find room for improvement, please feel free to contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants