Skip to content

Commit

Permalink
fix: inclusive gateway is fully supported in 8.6 (#1078)
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathanlukas authored Dec 5, 2024
1 parent df51c90 commit f0fb52a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

public class InclusiveGatewayVisitor extends AbstractGatewayVisitor {
private static final SemanticVersion FORK_AVAILABLE_VERSION = SemanticVersion._8_1;
private static final SemanticVersion JOIN_AVAILABLE_VERSION = SemanticVersion._8_6;
public static final String ELEMENT_LOCAL_NAME = "inclusiveGateway";

@Override
Expand All @@ -37,7 +38,7 @@ protected SemanticVersion availableFrom(DomElementVisitorContext context) {
if (isNotJoining(context.getElement())) {
return FORK_AVAILABLE_VERSION;
}
return null;
return JOIN_AVAILABLE_VERSION;
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ void testOrGateways() {
assertThat(joinGateway.getMessages()).hasSize(1);
assertThat(joinGateway.getMessages().get(0).getMessage())
.isEqualTo(
"Element 'Inclusive Gateway' is not supported in Zeebe version '8.0.0'. Please review.");
"Element 'Inclusive Gateway' is not supported in Zeebe version '8.0.0'. It is available in version '8.6.0'.");
}

@Test
Expand All @@ -154,7 +154,8 @@ void testOrGateways_8_1() {
BpmnElementCheckResult joinGateway = result.getResult("JoinGateway");
assertThat(joinGateway.getMessages()).hasSize(1);
assertThat(joinGateway.getMessages().get(0).getMessage())
.isEqualTo("A joining inclusive gateway is not supported.");
.isEqualTo(
"Element 'Inclusive Gateway' is not supported in Zeebe version '8.1.0'. It is available in version '8.6.0'.");
}

@Test
Expand Down

0 comments on commit f0fb52a

Please sign in to comment.