Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Slides Page: 'Upload from URL' link lacks visual focus indicator #1018

Open
nwanduka opened this issue Jul 25, 2024 · 4 comments
Labels

Comments

@nwanduka
Copy link
Contributor

Describe the bug
The 'Upload from URL' and 'Upload from local' links in the slide upload modal are focusable but lack a visual indicator when they receive focus.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Slides'
  2. Click on 'Upload'
  3. Press the tab key to highlight all interactive elements
  4. You'll notice that other elements have a visual focus indicator except the 'upload from url' link.

Expected behavior
Interactive elements should not only be keyboard accessible but also have a visual focus indicator.

Screenshots
image

image

@nwanduka nwanduka added the bug label Jul 25, 2024
@DAAS2
Copy link

DAAS2 commented Oct 7, 2024

Hi @nwanduka

I'd like to work on this issue! Could you please assign it to me?
Thanks.

@birm
Copy link
Member

birm commented Oct 9, 2024

Hi @DAAS2 we don't assign issues usually, but if you want to work on something that you've identified, open a PR!

@rahulptl165
Copy link

Hi, @birm is this issue still opened, i want to work on this .

@rajku-dev
Copy link

Hi, @birm I have created a pull request fixing this bug.

birm added a commit that referenced this issue Nov 29, 2024
[FIX]: Add visual focus indicator to 'Upload from URL' and 'Upload from local' links (#1018)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants