Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

css table fixes #63

Open
jhnc opened this issue May 21, 2014 · 0 comments · May be fixed by #89
Open

css table fixes #63

jhnc opened this issue May 21, 2014 · 0 comments · May be fixed by #89

Comments

@jhnc
Copy link

jhnc commented May 21, 2014

Related to misd-service-development/drupal-cambridge-theme#42 I think there may be a typo in the stylesheet. It currently selects "table OR class" rather than "table AND class".

Also an additional place where the campl-table-custom class could be used (although I think that may also be an extraneous comma at work in the original source of this presumably compiled file):

--- orig/full-stylesheet.css
+++ new/full-stylesheet.css
@@ -1438,8 +1438,7 @@
 .campl-main-content h1, 
 .campl-main-content h2 {color:#106470 }

-table, 
-.campl-table-bordered {border-bottom:2px solid #28828a;}
+table .campl-table-bordered {border-bottom:2px solid #28828a;}
 th{background:#28828a;color:#fff}
 th.campl-alt{background:#fff;color:#28828a}
 .campl-table-striped tbody tr:nth-child(odd) td,
@@ -1499,8 +1498,7 @@
 .campl-theme-1 .campl-main-content h1, 
 .campl-theme-1 .campl-main-content h2 {color:#003e74 }

-.campl-theme-1 table, 
-.campl-theme-1 .campl-table-bordered {border-bottom:2px solid #0072cf;}
+.campl-theme-1 table .campl-table-bordered {border-bottom:2px solid #0072cf;}
 .campl-theme-1 th{background:#0072cf;color:#fff}
 .campl-theme-1 th.campl-alt{background:#fff;color:#0072cf}
 .campl-theme-1 .campl-table-striped tbody tr:nth-child(odd) td,
@@ -1559,8 +1557,7 @@
 .campl-theme-2 .campl-main-content h1, 
 .campl-theme-2 .campl-main-content h2 {color:#106470 }

-.campl-theme-2 table, 
-.campl-theme-2 .campl-table-bordered {border-bottom:2px solid #28828a;}
+.campl-theme-2 table .campl-table-bordered {border-bottom:2px solid #28828a;}
 .campl-theme-2 th{background:#28828a;color:#fff}
 .campl-theme-2 th.campl-alt{background:#fff;color:#28828a}
 .campl-theme-2 .campl-table-striped tbody tr:nth-child(odd) td,
@@ -1619,8 +1616,7 @@
 .campl-theme-3 .campl-main-content h1, 
 .campl-theme-3 .campl-main-content h2 {color:#422e5d }

-.campl-theme-3 table, 
-.campl-theme-3 .campl-table-bordered {border-bottom:2px solid #8f2b8c;}
+.campl-theme-3 table .campl-table-bordered {border-bottom:2px solid #8f2b8c;}
 .campl-theme-3 th{background:#8f2b8c;color:#fff}
 .campl-theme-3 th.campl-alt{background:#fff;color:#8f2b8c}
 .campl-theme-3 .campl-table-striped tbody tr:nth-child(odd) td,
@@ -1679,8 +1675,7 @@
 .campl-theme-4 .campl-main-content h1, 
 .campl-theme-4 .campl-main-content h2 {color:#304220 }

-.campl-theme-4 table, 
-.campl-theme-4 .campl-table-bordered {border-bottom:2px solid #57831a;}
+.campl-theme-4 table .campl-table-bordered {border-bottom:2px solid #57831a;}
 .campl-theme-4 th{background:#57831a;color:#fff}
 .campl-theme-4 th.campl-alt{background:#fff;color:#57831a}
 .campl-theme-4 .campl-table-striped tbody tr:nth-child(odd) td,
@@ -1738,8 +1733,7 @@
 .campl-theme-5 .campl-main-content h1, 
 .campl-theme-5 .campl-main-content h2 {color:#c44101 }

-.campl-theme-5 table, 
-.campl-theme-5 .campl-table-bordered {border-bottom:2px solid #df671d;}
+.campl-theme-5 table .campl-table-bordered {border-bottom:2px solid #df671d;}
 .campl-theme-5 th{background:#df671d;color:#fff}
 .campl-theme-5 th.campl-alt{background:#fff;color:#df671d}
 .campl-theme-5 .campl-table-striped tbody tr:nth-child(odd) td,
@@ -1798,8 +1792,7 @@
 .campl-theme-6 .campl-main-content h1, 
 .campl-theme-6 .campl-main-content h2 {color:#851735 }

-.campl-theme-6 table, 
-.campl-theme-6 .campl-table-bordered {border-bottom:2px solid #d61746;}
+.campl-theme-6 table .campl-table-bordered {border-bottom:2px solid #d61746;}
 .campl-theme-6 th{background:#d61746;color:#fff}
 .campl-theme-6 th.campl-alt{background:#fff;color:#d61746}
 .campl-theme-6 .campl-table-striped tbody tr:nth-child(odd) td,
@@ -1856,8 +1849,7 @@
 .campl-theme-7 .campl-main-content h1, 
 .campl-theme-7 .campl-main-content h2 {color:#404040 }

-.campl-theme-7 table, 
-.campl-theme-7 .campl-table-bordered {border-bottom:2px solid #8C8989;}
+.campl-theme-7 table .campl-table-bordered {border-bottom:2px solid #8C8989;}
 .campl-theme-7 th{background:#8C8989;color:#fff}
 .campl-theme-7 th.campl-alt{background:#fff;color:#8C8989}
 .campl-theme-7 .campl-table-striped tbody tr:nth-child(odd) td,
@@ -2344,7 +2336,7 @@


        /* remove residual styling from tables and show by default */
-       table, .campl-table-bordered table, .campl-table-bordered th, .campl-table-bordered td, .campl-table-bordered tr {border-color:#E4E4E4!important}
+       table:not(.campl-table-custom), .campl-table-bordered table, .campl-table-bordered th, .campl-table-bordered td, .campl-table-bordered tr {border-color:#E4E4E4!important}
        caption{ border: 1px solid #E4E4E4!important; page-break-inside: avoid;}
        .campl-responsive-table table{display:block!important}
@tombsar tombsar mentioned this issue May 30, 2019
Open
tombsar pushed a commit to tombsar/Project-Light that referenced this issue May 30, 2019
Apply borders to table.campl-table-bordered only
d0cf4bd 
The existing rule applied a bottom border to all tables regardless of class, which looked unintentional.

Fixes cambridgeuniversity#63, cambridgeuniversity#81
@tombsar tombsar linked a pull request May 30, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply borders to table.campl-table-bordered only tombsar/Project-Light
1 participant
@jhnc