Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content height calculation should include all columns #52

Open
thewilkybarkid opened this issue Oct 11, 2013 · 0 comments
Open

Content height calculation should include all columns #52

thewilkybarkid opened this issue Oct 11, 2013 · 0 comments

Comments

@thewilkybarkid
Copy link
Contributor

While #51 fixed the height calculation for the content area columns, the problem still exists that not all columns are included in the calculation (only a .campl-tertiary-navigation, a .campl-secondary-content and a .campl-main-content are).

For example, when there is a .campl-main-content-sub-column longer than any of these the following happens:

image

One change the site could make is to make the .campl-main-content-sub-column part of a nested grid inside the .campl-main-content. But I think the JavaScript should instead find all columns inside the .campl-content (taking care not to include nested columns) and work on those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant