Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit defined errors #119

Closed
fernandopradocabrillo opened this issue Jun 26, 2024 · 1 comment · Fixed by #126
Closed

Revisit defined errors #119

fernandopradocabrillo opened this issue Jun 26, 2024 · 1 comment · Fixed by #126
Assignees
Labels
Fall24 Fall 24 release preparation

Comments

@fernandopradocabrillo
Copy link
Collaborator

Problem description

We currently have a couple errors that either don't have a real use case or are not align with the rest of the CAMARA APIs.

  1. Error 409 -> what is the usecase for this error? I don't think we have one, maybe we should remove it for the v0.5.0
  2. Error 404 SIM_SWAP.UNKNOWN_PHONE_NUMBER-> This is the only API where we have a specific error to cover that the phone number doesn't belong to the Operator. I propose to remove it and include this case in the generic 404 NOT_FOUND for consistency.

Expected behavior

  1. Error 409 -> being removed from the spec
  2. Error 404 SIM_SWAP.UNKNOWN_PHONE_NUMBER -> being removed from the spec and included in generic 404 NOT_FOUND
@fernandopradocabrillo fernandopradocabrillo self-assigned this Jun 26, 2024
@gregory1g
Copy link
Collaborator

According to camaraproject/Commonalities#233 the API must issue 403 - INVALID_TOKEN_CONTEXT when msisdn provided in the payload does not match msisdn extracted from the access token.
This must be added to SimSwap definition as well (currently the only defined 403 case is "Phone number cannot be deducted from access token context")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fall24 Fall 24 release preparation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants