Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[device-status-subscriptions]: remove allOf in sinkcredential #226

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

dfischer-tech
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Removing this allOf.
It was discovered for some code-generator, it will produce unexpected behaviours having the description inside the allOf.

Which issue(s) this PR fixes:

Fixes #225

Changelog input

[device-status-subscriptions]: remove `allOf` in `sinkCredential` in `SubscriptionRequest` component

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7
Copy link
Collaborator

@akoshunyadi As this is already defined as such in the yaml template for first meta release, this is not an issue to merge this before next MR. But no problem for me to keep it.

@akoshunyadi
Copy link
Collaborator

@akoshunyadi As this is already defined as such in the yaml template for first meta release, this is not an issue to merge this before next MR. But no problem for me to keep it.

Yes, the template has it correctly, so it's a kind of bug here. But I wouldn't create a fix for it, just release in Spring25.

@akoshunyadi akoshunyadi merged commit 067ce04 into camaraproject:main Dec 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants