Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release r1.2 for M4 of CAMARA Fall24 release #202

Merged
merged 13 commits into from
Sep 10, 2024

Conversation

akoshunyadi
Copy link
Collaborator

What type of PR is this?

  • subproject management

What this PR does / why we need it:

Prepare the release r1.2 for M4 of the CAMARA Fall24 release.

Which issue(s) this PR fixes:

Special notes for reviewers:

Changelog input

Additional documentation

@bigludo7
Copy link
Collaborator

Look very good - Thanks @akoshunyadi

We need to add @hdamker in the loop for a check before to add release management as reviewer.

@hdamker
Copy link
Contributor

hdamker commented Aug 26, 2024

We need to add @hdamker in the loop for a check before to add release management as reviewer.

@bigludo7 thanks, but actually I'm acting here more on behalf of the RM team.

@akoshunyadi Looks good to me, except the README section "Release Information". You now left no information at all here. What other APIs have done:

  • keeping information about the latest public release with the list of APIs and the direct links
  • followed by two lines:
* Former releases and pre-releases of this repository are available in https://github.com/camaraproject/§repo_name§/releases
* For changes see [CHANGELOG.md](https://github.com/camaraproject/§repo_name§/blob/main/CHANGELOG.md)

An example you can find in release PR of HomeDeviceQod.

Alternative (if you don't want to have the latest release mentioned) - but then the four APIs are not mentioned in the README:

* The latest release is available in https://github.com/camaraproject/§repo_name§/releases/latest
* Other releases and pre-release are available in https://github.com/camaraproject/§repo_name§/releases
* For changes see [CHANGELOG.md](https://github.com/camaraproject/§repo_name§/blob/main/CHANGELOG.md)

@akoshunyadi
Copy link
Collaborator Author

@hdamker actually the latest release line is still there, I only removed the block with the latest prerelease

@hdamker
Copy link
Contributor

hdamker commented Aug 27, 2024

@hdamker actually the latest release line is still there, I only removed the block with the latest prerelease

ah, yes, it was int he collapsed part before the "note" - fine for me

@akoshunyadi akoshunyadi marked this pull request as ready for review August 28, 2024 07:44
@akoshunyadi akoshunyadi requested a review from a team August 28, 2024 07:46
@akoshunyadi akoshunyadi self-assigned this Aug 30, 2024
@akoshunyadi
Copy link
Collaborator Author

All PRs have been merged, this PR has been updated. Kindly requesting final reviews @bigludo7 @sachinvodafone @camaraproject/release-management_maintainers

@bigludo7
Copy link
Collaborator

Great works @akoshunyadi
One small comment, probably the checklist should be aligned with https://github.com/camaraproject/ReleaseManagement/blob/main/documentation/API-Readiness-Checklist.md meaning that we should have the magic sentences down and link.

Not a blocker for me but for global consistency.

@akoshunyadi
Copy link
Collaborator Author

@bigludo7 actually I removed that filling aid because I thought it's only for the first editor... this is what I saw in some other subprojects e.g. DeviceLocation
The Note and the link to the template are still there.

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
Thanks for the hard work

@shilpa-padgaonkar
Copy link
Collaborator

@akoshunyadi
Copy link
Collaborator Author

@soadeyemo
Copy link

soadeyemo commented Sep 9, 2024

All now OK. LGTM from release mgmt.
Update the tracker and please create the release.

@akoshunyadi akoshunyadi merged commit 9911d1a into camaraproject:main Sep 10, 2024
1 check passed
@tanjadegroot
Copy link

@bigludo7 actually I removed that filling aid because I thought it's only for the first editor... this is what I saw in some other subprojects e.g. DeviceLocation The Note and the link to the template are still there.

@akoshunyadi I think the comment was that the API-Readiness-Checklist.md should have the actual clickable links in the table, rather than just text. Something to take that up for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants