-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release r1.2 for M4 of CAMARA Fall24 release #202
Prepare release r1.2 for M4 of CAMARA Fall24 release #202
Conversation
Look very good - Thanks @akoshunyadi We need to add @hdamker in the loop for a check before to add release management as reviewer. |
@bigludo7 thanks, but actually I'm acting here more on behalf of the RM team. @akoshunyadi Looks good to me, except the README section "Release Information". You now left no information at all here. What other APIs have done:
An example you can find in release PR of HomeDeviceQod. Alternative (if you don't want to have the latest release mentioned) - but then the four APIs are not mentioned in the README:
|
@hdamker actually the latest release line is still there, I only removed the block with the latest prerelease |
ah, yes, it was int he collapsed part before the "note" - fine for me |
All PRs have been merged, this PR has been updated. Kindly requesting final reviews @bigludo7 @sachinvodafone @camaraproject/release-management_maintainers |
Great works @akoshunyadi Not a blocker for me but for global consistency. |
@bigludo7 actually I removed that filling aid because I thought it's only for the first editor... this is what I saw in some other subprojects e.g. DeviceLocation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Thanks for the hard work
One small point: I did not find this text https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#appendix-a-infodescription-template-for-device-identification-from-access-token in the spec files. |
Done. |
All now OK. LGTM from release mgmt. |
@akoshunyadi I think the comment was that the API-Readiness-Checklist.md should have the actual clickable links in the table, rather than just text. Something to take that up for the next release. |
What type of PR is this?
What this PR does / why we need it:
Prepare the release r1.2 for M4 of the CAMARA Fall24 release.
Which issue(s) this PR fixes:
Special notes for reviewers:
Changelog input
Additional documentation