Create Gherkin tests for device-reachability-status-subscriptions & device-roaming-status-subscriptions #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gherkin tests for device-reachability-status-subscriptions device-connectivity-status-subscriptions
akoshunyadi
changed the title
mdomale
changed the title
|
Updated as per new camara guidelines |
mdomale
requested review from
eric-murray,
bigludo7,
sachinvodafone and
akoshunyadi
as code owners
|
@bigludo7 @sachinvodafone PR is updated aligned with comments from other PR's .Kindly review cc @akoshunyadi |
bigludo7
reviewed
Aug 30, 2024
There was a problem hiding this comment.
Thanks @mdomale @akoshunyadi
This is very good.
Very very small comments linked to copy/paste from geofencing.
As soon as fixed I will approve
code/Test_definitions/device-reachability-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-reachability-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-reachability-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-reachability-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-roaming-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-roaming-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-roaming-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-roaming-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
|
@bigludo7 @sachinvodafone PR updated ,kindly review .cc @akoshunyadi |
akoshunyadi
reviewed
Aug 30, 2024
code/Test_definitions/device-reachability-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-reachability-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-reachability-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-reachability-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-reachability-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-roaming-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-roaming-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-roaming-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-roaming-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/device-roaming-status-subscriptions.feature
Outdated
Show resolved
Hide resolved
|
@bigludo7 @akoshunyadi PR updated |
akoshunyadi
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gherkin tests for
device-reachability-status-subscriptions
device-roaming-status-subscriptions
What type of PR is this?
What this PR does / why we need it:
Gherkin tests for device-reachability-status-subscriptions &
device-roaming-status-subscriptions
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.