Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch device structure to optional #179

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

bigludo7
Copy link
Collaborator

@bigludo7 bigludo7 commented Jul 3, 2024

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature

What this PR does / why we need it:

Shift device structure cardinality to optional has the device identifier could be obtained from the 3-legs process.

Which issue(s) this PR fixes:

Fixes #173

Special notes for reviewers:

Changelog input

 release-note
- Device structure is now optional has the device identifier could be obtained from the 3-legs process.

Additional documentation

This section can be blank.

docs

Copy link

github-actions bot commented Jul 3, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 5 0 7.77s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.83s
✅ YAML yamllint 5 0 0.84s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@bigludo7
Copy link
Collaborator Author

bigludo7 commented Jul 5, 2024

@sachinvodafone @akoshunyadi @fernandopradocabrillo Gentle reminder for this one as is it a simple one.
As we're close to the finish line and there is few other topic to adress for these API like error code.
Thanks

@bigludo7 bigludo7 merged commit fa5b407 into main Jul 8, 2024
1 check passed
@bigludo7 bigludo7 deleted the Switch-device-to-optional branch July 8, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Device attribute optional in device-roaming-status & device-reachability-status
3 participants