Update device error model #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandopradocabrillo
requested review from
eric-murray,
bigludo7,
sachinvodafone and
akoshunyadi
as code owners
|
@fernandopradocabrillo Agree with you to keep it but in order to be explicit the code should not be: |
|
Hi @fernandopradocabrillo
Following points are open:
|
I'm not sure, I see that in geofencing it is also SUBSCRIPTION_MISMATCH: https://github.com/camaraproject/DeviceLocation/blob/main/code/API_definitions/geofencing-subscriptions.yaml#L1166 do you know if there is any conversation right now in commonalities regarding the errors in subscriptions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Align error model with Commonalities for meta Spring25
Which issue(s) this PR fixes:
Fixes #230
Special notes for reviewers:
In the subscriptions APIs there is one error that I'm not sure if we have to update or not.
It looks like it is the equivalent to
403 INVALID_TOKEN_CONTEXT. It may make sense to keep it since thedeviceobject is required when creating the subscription, regardless of the token type. I tend to think we should keep it.