-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit initialEvent for event type org.camaraproject.roaming-status-subscriptions.v0.roaming-status
#218
Comments
Are we proposing to refine the API guideline definition for IntialEvent, or suggesting to add this information directly into our specification? I believe , the API guideline does state clearly that the user will receive an immediate response with the current state when initialEvent is set to true. |
I was thinking adding the information in the specification.
If you think that is is not necessary to add this precision I'm fine. |
As I see that this behavior is already in the guidelines, so I would prefer to improve the existing definition in guideline itself if it is not clear. This will make it clearer and more consistent for all other APIs. Lets wait for others comment/preference on this. |
In Design Guidelines there are general defintions. When initialEvent in Roaming status event is true then the subscription to this event almost covers the call to If there is a value to indicate that the notification is related to initialEvent it can be done as proposed here: |
As @PedroDiez pointed out here, Design Guidelines state: "Set to true by API consumer if consumer wants to get an event as soon as the subscription is created and current situation reflects event request." So technically, this event type shouldn't support If the initialEvent definition can't be changed, then maybe we should consider adding an optional |
Agree with this, because generally these events are raised when a transition happens, and initialEvent is to request the event when the condition indicated in the subscription is already in place. So:
|
In my view, the suggestion on 'roaming event-type' seems to be overriding the |
We can also say, that we don't skip the check for current situation, but we do the same in both cases :-) |
@akoshunyadi I used that suggestion and added in the table I added to #222 conversation. |
Problem description
For event type
org.camaraproject.roaming-status-subscriptions.v0.roaming-status
we have to indicate clearly the expected behavior if initialEvent is set to TrueExpected action
In this case do we expect to send immediately a notification with the current status? I guess yes but it should be explicitly documented
Additional context
Following discussion with @gmuratk
The text was updated successfully, but these errors were encountered: