Create connected-network-type.yaml #158
Conversation
|
@camaraproject/device-status_codeowners I guess this can be moved together with #171 to the newly created https://github.com/camaraproject/DeviceQualityIndicator, do you agree? |
I think the quality indicator is something different. It will need different inputs, e.g. the network type, to provide a network quality indication. |
Amended per API Backlog/Device Status discussion (ref Device Status [PR 158](camaraproject/DeviceStatus#158)
akoshunyadi
requested review from
bigludo7,
sachinvodafone and
akoshunyadi
as code owners
|
Thank you for all the comments over the past months. Since 'Draft' label is removed, we'll provide responses/edits soon. |
Updates: - Use of UNKNOWN for undetermined connection [technology] - Simplified list of connection technologies - Updates to Examples and API documentation in line with above points
Update v0 - vwip Corrected tag with matching strings
changed api-name to connected-network-type changed path to /retrieve only added to description of /retrieve method changed schema label from RequestConnectedNetworkType to ConnectedNetworkTypeRequest
Co-authored-by: Eric Murray <[email protected]>
Co-authored-by: Eric Murray <[email protected]>
|
@gmuratk |
| required: | ||
| - device |
There was a problem hiding this comment.
Sorry - last minute review. device can't be required as a 3-legged token may be used. In that case, the request body would be an empty JSON object
| required: | |
| - device |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
#143 requests this enhancement/feature as new API under Device Status.
Which issue(s) this PR fixes:
Fixes #143
Special notes for reviewers:
Proposal doesn't include the subscriptions portion.
Changelog input
Additional documentation
This section can be blank.