Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove subscriptions #69

Closed
Kevsy opened this issue Aug 14, 2024 · 1 comment
Closed

fix: remove subscriptions #69

Kevsy opened this issue Aug 14, 2024 · 1 comment
Assignees
@Kevsy
Labels
align-design-guidelines connectivity-insights

Comments

@Kevsy
Copy link
Collaborator

Kevsy commented Aug 14, 2024

Problem description

Subscriptions must be a separate API per API Design Guidelines

Expected behavior

Remove subscriptions from check-network-quality API
Create separate issue for new subscriptions API

Additional context

Per comment in review of #67
@Kevsy Kevsy self-assigned this Aug 14, 2024
Kevsy added a commit that referenced this issue Aug 14, 2024
@Kevsy
Update connectivity-insights.yaml
fedf496 
Fixes: 
#68
#69
#70 
#71 
#72 
#73
@Kevsy Kevsy mentioned this issue Aug 14, 2024
Merged
@Kevsy
Copy link
Collaborator Author

Kevsy commented Aug 15, 2024

Fix provided in fedf496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kevsy Kevsy

Labels
align-design-guidelines connectivity-insights
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kevsy @maheshc01