From 3ad4b95d741de466a267fadb7af4c645d79ddc30 Mon Sep 17 00:00:00 2001 From: Rafal Artych <121048129+rartych@users.noreply.github.com> Date: Thu, 5 Dec 2024 20:20:49 +0100 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Pedro Díez García --- CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8471f49d..8a124114 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,14 +30,14 @@ This release contains documents and artifacts of Commonalities version 0.5.0-alp ### Changed * Normalization of error status and code allowed values using `enum` by @PedroDiez in https://github.com/camaraproject/Commonalities/pull/316 -* Guidelines for subscription and event notification in API Design Guideliness by @bigludo7 in https://github.com/camaraproject/Commonalities/pull/313 main changes: +* Guidelines for subscription and event notification in API Design Guidelines by @bigludo7 in https://github.com/camaraproject/Commonalities/pull/313 main changes: - updated `terminationReason` in event notification type "subscription-ends" - updated description of `sink` and `sinkCredential` attributes for subscription - added rules for subscriptions with device identifier attribute - added section 11.7 Resource access restriction relevant to subscriptions - added clarification on `expiresAt` attribute for subscription * Updated error codes and changed `info.description` template for device / phone number identifiers in Appendix A in API Design Guideliness by @eric-murray in https://github.com/camaraproject/Commonalities/pull/324 and https://github.com/camaraproject/Commonalities/pull/346 -* Guidelines regarding mandatory error `status` and alignment of error codes related to identifiers in API Design Guideliness by @PedroDiez in https://github.com/camaraproject/Commonalities/pull/329 and https://github.com/camaraproject/Commonalities/pull/351 +* Guidelines regarding mandatory error `status` and alignment of error codes related to identifiers in API Design Guidelines by @PedroDiez in https://github.com/camaraproject/Commonalities/pull/329 and https://github.com/camaraproject/Commonalities/pull/351 ### Fixed * Clarification on api-name, filenames and servers object by @rartych in https://github.com/camaraproject/Commonalities/pull/333