Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Results of applying gherkinlint to the test definitions #180

Open
PedroDiez opened this issue Sep 4, 2024 · 3 comments · May be fixed by #191
Open

Results of applying gherkinlint to the test definitions #180

PedroDiez opened this issue Sep 4, 2024 · 3 comments · May be fixed by #191
Labels
correction API specification needs correction

Comments

@PedroDiez
Copy link
Collaborator

Problem description
Topic to be covered after MetaRelease v0.4.
@rartych has kindly passed linter rules based on Commonalities/PR#292

Expected behavior
Correct test files according to linter points identified

Alternative solution
N/A

Additional context
Results attached
CarrierBillint _Result2.txt
CarrierBilling_Result.txt
@PedroDiez PedroDiez added the correction API specification needs correction label Sep 4, 2024
@PedroDiez
Copy link
Collaborator Author

@rartych provides input
With this tests definition can be improved.
Next step is to redefine linter flows (commonalities work).

@PedroDiez check this in order to review the tests definition

@PedroDiez
Copy link
Collaborator Author

After the analysis. Rules works well, except this one:

0 File names should be written in kebab-case e.g. "carrier-billing-refund-retrieve-payment-remaining-amount.feature" file-name

As per ATP testing guidelines, the operationId can be part of the test file and operationId follow lowerCamelCase format. So this rule should be warning level, just to check the rest of the filename and maybe some additional information about its meaning should be provided for their output

@PedroDiez PedroDiez linked a pull request Nov 12, 2024 that will close this issue
Open
@PedroDiez
Copy link
Collaborator Author

27/NOV: WG output. Wait some time in order to have camaraproject/Commonalities#292 merged. If not merge this PR to have at least some linter for testing enabled and later aligned with commonalities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
correction API specification needs correction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable Gherkin Linting PedroDiez/CarrierBillingCheckOut
1 participant
@PedroDiez