Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API aligment with Commonalities #58

Merged
merged 4 commits into from
Nov 1, 2024
Merged

API aligment with Commonalities #58

merged 4 commits into from
Nov 1, 2024

Conversation

PedroDiez
Copy link
Collaborator

@PedroDiez PedroDiez commented Oct 19, 2024 •
edited
Loading

What type of PR is this?

  • enhancement/feature
  • documentation
  • subproject management

What this PR does / why we need it:

Alignment of API with Commonalities.

Current status: READY_FOR_REVIEW

Which issue(s) this PR fixes:

Fixes #57

Special notes for reviewers:

1st Commit: b9eab10

  • API file name aligned to be kebab-case
  • Remove termsOfService and contact from info object.
  • Adding extension field x-camara-commonalities in info object
  • Align servers object
  • Set version to wip and in servers[*].url to vwip to follow guidelines moving between releases
  • Align phoneNumber description based on Common Glossary

2nd Commit: 1af9b16

3rd Commit: 73a5ddc

  • Exceptions alignment

4th Commit: 2478e23

  • Fix linter rule

Changelog input

API Aligment with Commonalities

Additional documentation

N/A

@PedroDiez PedroDiez self-assigned this Oct 19, 2024
@PedroDiez PedroDiez added documentation Improvements or additions to documentation enhancement New feature or request subproject management Indicating issues with subproject repository or release management process labels Oct 19, 2024
@PedroDiez PedroDiez requested a review from rartych October 19, 2024 10:38
@PedroDiez
Copy link
Collaborator Author

PedroDiez commented Nov 1, 2024 •
edited
Loading

MERGED as no further comments received up to 31/10

@PedroDiez PedroDiez merged commit c074713 into camaraproject:main Nov 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grgpapadopoulos grgpapadopoulos grgpapadopoulos approved these changes

@ksl4dtit ksl4dtit Awaiting requested review from ksl4dtit ksl4dtit is a code owner

@rartych rartych Awaiting requested review from rartych

Assignees

@PedroDiez PedroDiez

Labels
documentation Improvements or additions to documentation enhancement New feature or request subproject management Indicating issues with subproject repository or release management process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API Aligment with Commonalities and Further enhancements
2 participants
@PedroDiez @grgpapadopoulos