Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #218

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

kurtmilam
Copy link
Member

npm audit reports a large number of vulnerabilities with the current dependencies.

I'm opening this as a draft, because it probably requires more work.

Additionally, in order to squash the last vulnerabilities, klipse will need to be updated: polytypic/klipse-github-docs-generator#2

Other than marked via klipse, npm audit reports no vulnerabilities when run on this branch, and all tests are passing.

@codecov-io
Copy link

codecov-io commented Dec 22, 2019

Codecov Report

Merging #218 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   99.88%   99.88%   +<.01%     
==========================================
  Files           1        1              
  Lines        1713     1719       +6     
==========================================
+ Hits         1711     1717       +6     
  Misses          2        2
Impacted Files Coverage Δ
dist/partial.lenses.cjs.js 99.88% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fd5f9a...ac75ae0. Read the comment docs.

@polytypic
Copy link
Member

Thanks! I’ve noticed this earlier and haven’t so far done anything to it due to all the vulnerabilities being only in devDependencies. It would be great to update the devDependencies so looking forward to finished PR! Hopefully NPM packages have matured a bit when it comes to vulnerabilities.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (5fd5f9a) to head (ac75ae0).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #218   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files           1        1           
  Lines        1713     1719    +6     
=======================================
+ Hits         1711     1717    +6     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants