-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add presentMut lens for always replacing the current history item instead of appending #9
base: master
Are you sure you want to change the base?
Conversation
…tead of appending
Thanks for the PR! Hmm... The basic idea and use case sounds reasonable. I added a few suggested changes. Mentioning the addition in the README would also be nice.
It has been a long time since I last worked on a frontend project (especially using Calmm-js) and I have kind of assumed everyone has already moved on to writing TS using LLM generated code. |
Wow, thanks for your fast response. I agree with your suggestions and applied them. I did not commit the regenerated docs and dist folder. Should this be done as part of the PR as well? |
I am currently working on a frontend project again and remebered your talks on calmmjs and discussion from back in 2016 in the CycleJS chat and at CycleConf. So I thought to give it a try to apply the calmmjs architecture to svelte. So far it works really nice. |
Would this be ready to be merged or anything still to be done? |
Currently the latest history entry is only replaced if the modification happens inside the globally configured time window.
This PR adds a new
H.presentMut
lens that always replaces the latest history entry instead of append to the log.This is useful for temporarily opting out of tracking changes. For example when updating a value based on the mouse position but only storing a new history value once the mouse button is released.
Not sure if is repository is still maintained but I would appreciate if this PR could be merged.