Remove ChronosInterface references and clean up ChronosDate and ChronosTime refs #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othercorey
commented
Sep 25, 2023
| @@ -18,22 +26,6 @@ following:: | |||
|
|
|||
| php composer.phar require "cakephp/chronos:^3.0" | |||
|
|
|||
| Overview | |||
There was a problem hiding this comment.
After fixing both the intro and this section, it felt like a duplicate. Merged into the intro at the top.
ADmad
reviewed
Sep 25, 2023
docs/en/index.rst
Outdated
| * Immutable date and datetime objects. | ||
| * ``Cake\Chronos\Chronos`` extends ``DateTimeImmutable`` and provides many helpers. | ||
| * ``Cake\Chronos\ChronosDate`` represents calendar dates unaffected by time or time zones. | ||
| * ``Cake\Chronos\ChronosTime`` repreents clock times independent of date or time zones. |
There was a problem hiding this comment.
Suggested change
| * ``Cake\Chronos\ChronosTime`` repreents clock times independent of date or time zones. | |
| * ``Cake\Chronos\ChronosTime`` represents clock times independent of date or time zones. |
othercorey
force-pushed
the
cleanup-docs
branch
from
77de970
to
9ef5f81
Compare
markstory
reviewed
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes ChronosInterface and cleans up list of classes provided by Chronos.
The docs need more information added, but this at least makes them correct.