Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github org/repos in markdown files #6524

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Update github org/repos in markdown files #6524

merged 2 commits into from
Nov 25, 2024

Conversation

taylanisikdemir
Copy link
Member

What changed?
Cadence repos are moved from github orgs named uber* to cadence-workflow recently. Redirection works fine but still updating links in readmes to avoid confusions in the future.

@taylanisikdemir taylanisikdemir enabled auto-merge (squash) November 25, 2024 22:32
davidporter-id-au
davidporter-id-au reviewed Nov 25, 2024
View reviewed changes
canary/README.md Outdated Show resolved Hide resolved
@taylanisikdemir taylanisikdemir enabled auto-merge (squash) November 25, 2024 23:00
Groxx
Groxx approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@Groxx Groxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all links seem to work, and +1 on changing all

abc  |
def|

to

abc|
|
def|

since that trailing-space feature is kinda fragile and not universally supported anyway.

@taylanisikdemir taylanisikdemir merged commit 9d268a0 into cadence-workflow:master Nov 25, 2024
17 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/github_org_readme_updates branch November 25, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidporter-id-au davidporter-id-au davidporter-id-au approved these changes

@Groxx Groxx Groxx approved these changes

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taylanisikdemir @Groxx @davidporter-id-au