Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update matching simulation test to support new task list partition config #6500

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

Shaddoll
Copy link
Member

What changed?
Update matching simulation test to support new task list partition config

Why?
To test new feature

How did you test it?
run simulation test locally

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.35%. Comparing base (6f6249b) to head (3436af5).
Report is 1 commits behind head on master.

Additional details and impacted files

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f6249b...3436af5. Read the comment docs.

numhistoryhosts: 1
matchingconfig:
nummatchinghosts: 4
simulationconfig:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep the simulationconfig section close to the default one as much as possible. Each scenario should differ from each other only in the dimensions it is supposed to highlight.

Copy link
Member

@taylanisikdemir taylanisikdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support for this mode to simulation. I guess plan is to make this mode default in all simulations once we ship the feature

@Shaddoll Shaddoll enabled auto-merge (squash) November 16, 2024 17:17
@Shaddoll Shaddoll merged commit 0105e2d into cadence-workflow:master Nov 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants