Add unit tests for wrapper calls #974
Merged
+145
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vilhamster
requested review from
Groxx,
abhishekj720,
natemort,
shijiesheng,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
jakobht
reviewed
Nov 27, 2024
src/test/java/com/uber/cadence/internal/sync/TestActivityEnvironmentInternalTest.java
Outdated
Show resolved
Hide resolved
jakobht
approved these changes
Nov 27, 2024
3vilhamster
force-pushed
the
servce-wrapper-tests
branch
from
98d1d32
to
29fef19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a generic test that goes over all methods in wrapper and ensures that underlying impl is called.
Why?
Improvign test coverage.
How did you test it?
Potential risks
Release notes
Documentation Changes