Added coverage for TestActivityExecutor private methods #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vilhamster
requested review from
Groxx,
abhishekj720,
natemort,
shijiesheng,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
3vilhamster
commented
Nov 26, 2024
| } | ||
|
|
||
| // Helper method to print all methods | ||
| private void printMethods(Class<?> clazz) { |
There was a problem hiding this comment.
I want to leave it for now since I'm trying to debug the next steps for WorkflowServiceWrapper. It looks very useful helper :)
jakobht
approved these changes
Nov 26, 2024
src/test/java/com/uber/cadence/internal/sync/TestActivityEnvironmentInternalTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added unit tests for internal unsupported methods.
This is a huge code smell and shows flows in the Class design, but we need to get the coverage, so refactoring internal pieces could be done later.
Methods are stubbed because they are implemented in workflowInterceptorbase, so the better way would be to extract actual common methods to the base and provide extra methods in the workflow implementation.
But for now I've managed to hack around the internals with reflection and get it covered.
Why?
Improvign code coverage
How did you test it?
Potential risks
Release notes
Documentation Changes