Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more tests to WorkflowExecutionUtils #970

Merged

Conversation

dkrotx
Copy link
Member

@dkrotx dkrotx commented Nov 26, 2024

What changed?
Should cover all the following path almost 100%:

prettyPrintDecisions
  prettyPrintDecision
    prettyPrintObject
      prettyPrintJson
        fixStackTrace

Nit change: moved methods around in the source-code to group better.

Why?
More code-coverage for test

How did you test it?
unit-tests in IDE

Potential risks

Release notes

Documentation Changes

Should cover all the following path almost 100%:
```
prettyPrintDecisions
  prettyPrintDecision
    prettyPrintObject
      prettyPrintJson
        fixStackTrace
```

Nit change: moved methods around in the source-code to group better.
@3vilhamster 3vilhamster merged commit 628fb21 into cadence-workflow:master Nov 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants