Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage for proto/TypeMapper.java #962

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

natemort
Copy link
Member

What changed?

  • Minor increase in test coverage

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.43%. Comparing base (f55ce55) to head (8feab0c).
Report is 8 commits behind head on master.

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55ce55...8feab0c. Read the comment docs.

Copy link
Member

@3vilhamster 3vilhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat :)
I wonder if we can have more of Parameterized in the tests to eliminate boilerplate.

@3vilhamster 3vilhamster merged commit c6a7a00 into cadence-workflow:master Nov 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants