Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to ActivityCompletionException #949

Merged

Conversation

timl3136
Copy link
Member

@timl3136 timl3136 commented Nov 6, 2024

What changed?
Add unit tests to ActivityCompletionException

Why?
Improve code coverage

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.61%. Comparing base (aa86d2a) to head (4be43e4).
Report is 9 commits behind head on master.

Additional details and impacted files

see 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa86d2a...4be43e4. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2626

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 292 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-1.3%) to 78.233%

Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/sync/CancellationScopeImpl.java 1 92.65%
src/main/java/com/uber/cadence/internal/sync/TestWorkflowEnvironmentInternal.java 21 54.14%
src/main/java/com/uber/cadence/internal/replay/SignalExternalWorkflowParameters.java 22 42.11%
src/main/java/com/uber/cadence/internal/compatibility/thrift/ErrorMapper.java 30 0.0%
src/main/java/com/uber/cadence/internal/testservice/TestWorkflowService.java 44 72.66%
src/main/java/com/uber/cadence/internal/logging/ReplayAwareLogger.java 174 6.95%
Totals Coverage Status
Change from base Build 2625: -1.3%
Covered Lines: 15167
Relevant Lines: 19387

💛 - Coveralls

@timl3136 timl3136 merged commit 48f66e6 into cadence-workflow:master Nov 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants